Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Log API Support for Virtual Gateways #222

Merged
merged 4 commits into from
Jun 29, 2020
Merged

Access Log API Support for Virtual Gateways #222

merged 4 commits into from
Jun 29, 2020

Conversation

rishijatia
Copy link
Contributor

Issue #, if available: 37

Description of changes:

Adding support for Logging per VirtualGateway.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fawadkhaliq
Copy link

Can you please update the files here [1] as well. appmesh controller uses them to build preview sdk [1]

[1]https://github.com/aws/aws-app-mesh-roadmap/tree/master/appmesh-preview/sdk
[2] https://github.com/aws/aws-app-mesh-controller-for-k8s/blob/preview/appmesh_models_override/setup.sh

@rishijatia
Copy link
Contributor Author

Hi @fawadkhaliq, thank you for pointing that out. I have added the required files.

Comment on lines +3294 to +3295
"shape": "Duration",
"documentation": "<p>An object that represents a per request timeout. The default value is 15 seconds. If you set a higher timeout, then make sure that the higher value is set for each App Mesh resource in a conversation. For example, if a virtual node backend uses a virtual router provider to route to another virtual node, then the timeout should be greater than 15 seconds for the source and destination virtual node and the route.</p>"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "for the source and destination" could use some clarification. Shouldn't it be the other way around? This is what I get from the description:

[VN w/ backend timeout=20] --> [VS] --> [VR + Route] --> [VN timeout=25]

But logically it seems like the VN using the other service as a backend should have a larger timeout. Like this:

[VN w/ backend timeout=25] --> [VS] --> [VR + Route] --> [VN timeout=20]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is auto-generated from our doc-model, can take this discussion offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants